Add WrapExecutor #477
Open
Add WrapExecutor #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavoiesl
force-pushed
the
seb-executor
branch
from
56b23f0
to
593c7f2
Compare
lavoiesl
force-pushed
the
seb-executor
branch
3 times, most recently
from
1f42ed1
to
2372bf0
Compare
|
@lavoiesl Thanks for your suggestion. With this improvement, I think we can restructure within Resty. I will consider this for Resty v3 |
- Expose an `Unwrap` method to leverage go's standard unwrapping - Let the error escape, such that hooks and end-users can access the `Temporary` information. - Do not wrap if the error already exposes `Temporary`, to honour it.
|
@jeevatkm Is there still a plan to release a v3? We ended up having to maintain a fork of resty because this hook proved essential to throttling, error handling, and metrics gathering. |
|
@lavoiesl I will aim this concept for v3. I know, I got delayed so much, I will make up for it. Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to wrap the request executor, granting full access to the request, response, and error.
Runs on every request attempt, before any request hook and after any response or error hook.
Can be useful to introduce throttling or add hooks that always fire, regardless of success or error.
Having access to the request even in case of errors means also having access to the request's context, which can be immensely helpful for proper error logging/reporting.
This PR is dependant on #478, to avoid re-wrapping
noRetryError